Skip to content

Make minimal excludes script more flexible #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2019
Merged

Make minimal excludes script more flexible #211

merged 1 commit into from
Jul 23, 2019

Conversation

@mikedickey
Copy link
Contributor

@mikedickey mikedickey commented Jul 9, 2019

Updated script used to generate list of files to exclude from minimal images, so that it supports major version numbers greater than 7. Note that manual review of file diffs for every major.minor and corresponding updates for this script is still recommended.

Updated script used to generate list of files to exclude from minimal…
38774b6 
… images, so that it supports major version numbers greater than 7. Note that manual review of file diffs for every major.minor and corresponding updates for this script is still recommended.
@mikedickey mikedickey requested review from arctan5x, bb03 and nwang92 July 9, 2019 18:37
@nwang92
Copy link
Contributor

nwang92 commented Jul 18, 2019

Let me see what's going on with this test failure

@nwang92
Copy link
Contributor

nwang92 commented Jul 18, 2019

Should be fixed with splunk/splunk-ansible#217:

$ pytest -sv tests/test_docker_splunk.py::TestDockerSplunk::test_compose_1so_custombuild
==================== test session starts ====================
platform darwin -- Python 2.7.15, pytest-4.0.2, py-1.7.0, pluggy-0.8.0 -- /Users/nwang/github/docker-splunk/venv/bin/python2.7
cachedir: .pytest_cache
rootdir: /Users/nwang/github/docker-splunk/tests, inifile: pytest.ini
collected 1 item

tests/test_docker_splunk.py::TestDockerSplunk::test_compose_1so_custombuild PASSED

==================== 1 passed in 139.93 seconds ====================

@mikedickey mikedickey merged commit 5982ddd into develop Jul 23, 2019
@mikedickey mikedickey deleted the minimal-excludes-flexibility branch July 23, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arctan5x arctan5x Awaiting requested review from arctan5x

2 more reviewers

@bb03 bb03 bb03 approved these changes

@nwang92 nwang92 nwang92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikedickey @nwang92 @bb03